Pub/Sub retry settings: needs common api between data & admin ops, better docs.

[stephenplusplus]

Copied from original issue: googleapis/google-cloud-node#2788

@kir-titievsky
January 9, 2018 4:42 PM

This is a bug to track progress on an email discussion about setting custom retry settings.

Previous suggestion:
In src/v1/publisher_client.js the gapicConfig contains the contents of the config file you mentioned, and it is passed down to gaxGrpc:

nodejs-pubsub/src/v1/publisher_client.js

Line 166 in 96fd4d6

var defaults = gaxGrpc.constructSettings(

var defaults = gaxGrpc.constructSettings(
  'google.pubsub.v1.Publisher',
  gapicConfig,
  opts.clientConfig,
  {'x-goog-api-client': clientHeader.join(' ')}
);

Here the third parameter, opts.clientConfig, gives configOverrides to gaxGrpc.constructSettings, and, given the name, I guess it might be able to override options.
opts.clientConfig comes from PublisherClient constructor parameter. So I guess you might try settings opts.clientConfig to override any default configuration.

If it does not work for you, please let me know - better with code example - and I'll create an issue for pubsub package.

[theacodes]

@kir-titievsky do you think this is release blocking? Does this affect the interface or is it something that can be changed post v1.0.0 without necessitating a major version bump?

[kir-titievsky]

I think this is release blocking, unless we are convinced that offering a consistent retry settings API across all operations will not require client library API changes.

[stephenplusplus]

Anything that is passed to the PubSub constructor gets passed to PublisherClient. Has the issue reporter tried the suggestion from the end of the opening post in this thread? (Seems like we are only seeing a piece of the conversation)

[stephenplusplus]

Should we close this one?

[lazharichir]

The current release 0.18.0 seems to offer this possibility of customizing retry settings from the Publisher, yet, it doesn't work for me.

pubsub.topic(topicName).publisher({ gaxOpts: { retry: null } }).publish(message);

I receive that message every seconds and it fails every single time (pushed to an HTTP-triggered Google Cloud Functions).

No documentation released yet but I dug in the NPM module's code. Any specific format to follow that I got wrong for the gaxOpts.retry ?

[jkwlui]

is this still an issue with the latest versions? @callmehiphop

[callmehiphop]

@kinwa91 I'm actually not 100% what the issue is describing, haha..

In regards to gapics, I can't tell if gax actually uses/caches any call options passed in via the client constructor, but as far as I can tell, it does not.

If this is about the hand-written Publisher client, it should be resolved.

[callmehiphop]

I think as far as providing publishing call options, this has been solved for a while. We could probably improve the client with the steps outlined in googleapis/google-cloud-node#2895, but I'll let @kir-titievsky make the call if that should hold up GA or not. Going to close this issue, but please feel free to re-open if you disagree!

[sduskis]

We should do a thorough review of the API before we go GA. We ought to do that sooner rather than later. I'll bring it up with Kir and crew.