Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert!: remove pullTimeout subscriber option #618

Merged
merged 2 commits into from
May 20, 2019
Merged

revert!: remove pullTimeout subscriber option #618

merged 2 commits into from
May 20, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented May 20, 2019

Relates to #468 (comment)

The PubSub team would prefer that we do not provide this option.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@callmehiphop callmehiphop requested review from bcoe and sduskis May 20, 2019 15:32
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          14       14           
  Lines         857      857           
  Branches      178      178           
=======================================
  Hits          839      839           
  Misses          2        2           
  Partials       16       16
Impacted Files Coverage Δ
src/message-stream.ts 97.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eedf0f...3a3f783. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Do I gather that pullTimeout was added in an attempt to address a specific user's problem, and it ultimately wasn't needed?

@callmehiphop
Copy link
Contributor Author

@bcoe yeah, that is pretty much the gist of why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants