Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various problems seem to be happening in regards to grpc-js #868

Closed
feywind opened this issue Jan 27, 2020 · 7 comments
Closed

Various problems seem to be happening in regards to grpc-js #868

feywind opened this issue Jan 27, 2020 · 7 comments
Assignees
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: investigating The issue is under investigation, which is determined to be non-trivial. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@feywind
Copy link
Collaborator

feywind commented Jan 27, 2020

Over the course of the last few months, I've been tracking a number of issues where the answer was "roll back to an earlier version", and often when I ask people to try the newest version, but sub in the gRPC C++ bindings, it also works fine. (Or sometimes even better than the older version.)

There is something going on there that needs to be figured out. I'm making this to track related things independently of adjacent issues.

Potentially related:
#679 (comment)
#788
#789
#818
#825
#850

@feywind feywind added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. status: investigating The issue is under investigation, which is determined to be non-trivial. labels Jan 27, 2020
@feywind feywind self-assigned this Jan 27, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jan 28, 2020
@feywind feywind added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Jan 30, 2020
@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 30, 2020
@Ezard
Copy link

Ezard commented Feb 5, 2020

@feywind I think #770 is another one

@feywind
Copy link
Collaborator Author

feywind commented Feb 5, 2020

After reading that issue, I think this may also fall into the bucket: #866

@feywind
Copy link
Collaborator Author

feywind commented Feb 12, 2020

Potentially related. #885

@yagodorea
Copy link

I saw some bugs were resolved by the latest pubsub release. Is this gRPC issue one of them? If changing the default binding can solve it, can't we make it the default binding in the lib?

@ThomWright
Copy link

Could I add grpc/grpc-node#767 as another example of things going wrong because of grpc-js?

Thanks for looking into this, we've been stuck on an old version (0.28.1) for almost a year. It's a case of choosing which bugs are least problematic (we're suffering from #574), and at the moment I'm still convinced that upgrading to v1 is too risky.

@ctavan
Copy link
Contributor

ctavan commented Mar 4, 2020

@ThomWright I can feel you 😉 Maybe to bolster you up a bit:

@google-cloud/pubsub@1.5.0
@grpc/grpc-js@0.6.18

is the first combination in months that really seems to work flawlessly for me, see #850 (comment).

lucyllewy pushed a commit to diddlesnaps/snapstats that referenced this issue Apr 30, 2020
Ref: googleapis/nodejs-pubsub#868
Signed-off-by: Daniel Llewellyn <daniel@bowlhat.net>
@feywind
Copy link
Collaborator Author

feywind commented May 5, 2020

The sort of gestalt I'm seeing lately is that grpc-js is really a lot more stable for everyone, so I'm going to go ahead and close this out. Please feel free to add more comments with examples of problems, though. These examples are being fed into internal notes about pain points everyone has been experiencing.

I'm hoping to get us onto grpc-js 1.x soon, as it's no longer marked as a pre-release.

@feywind feywind closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: investigating The issue is under investigation, which is determined to be non-trivial. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

6 participants