Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set only the Publish method to have a timeout of 5000ms #1416

Merged
merged 3 commits into from Nov 15, 2021

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Nov 3, 2021

Fixes: #1414

This was applied to all methods, and should only have applied to Publish.

@feywind feywind requested review from a team as code owners November 3, 2021 22:05
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Nov 3, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
@feywind
Copy link
Collaborator Author

feywind commented Nov 3, 2021

@kamalaboulhosn Do you mind giving this a look-over to make sure I tweaked the right number this time? Thanks! :D

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2021
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2021
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2021
@feywind feywind merged commit 1e11001 into googleapis:main Nov 15, 2021
@feywind feywind deleted the timeouts-take-2 branch November 15, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topic creation fails with DEADLINE_EXCEEDED error
3 participants