Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "with response" versions of ack/nack/modack #1588

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Jun 14, 2022

This adds ackWithResponse(), nackWithResponse(), and modAckWithResponse(), along with Promises that will simply complete to Success for this step (doc step 4).

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Jun 14, 2022
@feywind feywind changed the base branch from exactly-once-1 to main June 14, 2022 20:39
@feywind feywind changed the base branch from main to exactly-once-1 June 14, 2022 20:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. size: l Pull request size is large. and removed size: l Pull request size is large. size: m Pull request size is medium. labels Jun 16, 2022
@feywind feywind marked this pull request as ready for review June 16, 2022 21:06
@feywind feywind requested review from a team as code owners June 16, 2022 21:06
@feywind feywind added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 16, 2022
@feywind
Copy link
Collaborator Author

feywind commented Jul 15, 2022

@meleu Unfortunately not. I'm working on finishing up the code work to get full exactly once support, but the approvals are taking a while.

@feywind feywind changed the base branch from exactly-once-1 to exactly-once-main July 15, 2022 19:15
@feywind feywind removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 15, 2022
@feywind feywind merged commit c9180de into googleapis:exactly-once-main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant