Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't do multiple drains per publish() in message queues unless requested #1691

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: don't do multiple drains per publish() in message queues unless requested #1691

merged 1 commit into from
Mar 6, 2023

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Mar 3, 2023

Fixes: #1690

@feywind feywind requested review from a team as code owners March 3, 2023 22:14
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Mar 3, 2023
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 3, 2023
@feywind feywind merged commit d9b3a63 into googleapis:main Mar 6, 2023
@feywind feywind deleted the gh1690-batch-timeout branch March 6, 2023 17:06
@release-please release-please bot mentioned this pull request Mar 6, 2023
Merged
@kimjoar kimjoar mentioned this pull request Mar 28, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messages queues don't wait for the next batch timeout if a previous one finishes
2 participants
@feywind @kamalaboulhosn