Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(legacy-v3): release 3.7.4 #1820

Merged

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Sep 8, 2023

🤖 I have created a release beep boop

3.7.4 (2023-09-08)

Bug Fixes

  • Always fill the topic and sub names when creating from a PubSub object (#1816) (ddf8b8a)
  • Make retry policy back off more aggressively for RPCs that retry RESOURCE_EXHAUSTD (#1806) (bfcf523)
  • Set grpc keepalive time|outs by default (#1814) (dedfdea)
  • Simplify logic for HTTP/1.1 REST fallback option (#1809) (ee09b69)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested review from a team as code owners September 8, 2023 18:42
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 8, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Sep 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Sep 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2023
@feywind feywind added the owlbot:ignore instruct owl-bot to ignore a PR label Sep 8, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Sep 8, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2023
@release-please release-please bot force-pushed the release-please--branches--legacy-v3--components--pubsub branch from 9c5f71c to 57d162e Compare September 8, 2023 19:47
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2023
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2023
@feywind feywind merged commit edaa213 into legacy-v3 Sep 11, 2023
18 checks passed
@feywind feywind deleted the release-please--branches--legacy-v3--components--pubsub branch September 11, 2023 19:23
@release-please
Copy link
Contributor Author

@release-trigger
Copy link

Triggered job: cloud-devrel/client-libraries/nodejs/release/googleapis/nodejs-pubsub/publish (2023-09-11T19:24:06.511Z)

To trigger again, remove the autorelease: triggered label (in a few minutes).

@release-tool-publish-reporter

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter

The release build failed! Please investigate!

@feywind
Copy link
Collaborator

feywind commented Sep 11, 2023

> tsc -p . && cp -r protos build/

node_modules/@opentelemetry/tracing/build/src/Span.d.ts:45:5 - error TS2416: Property 'recordException' in type 'Span' is not assignable to the same property in base type 'Span'.
  Type '(exception: Exception, time?: TimeInput | undefined) => void' is not assignable to type '{ (exception: Exception, time?: TimeInput | undefined): void; (exception: Exception, attributes?: Attributes | undefined, time?: TimeInput | undefined): void; }'.
    Types of parameters 'time' and 'attributes' are incompatible.
      Type 'Attributes | undefined' is not assignable to type 'TimeInput | undefined'.
        Type 'Attributes' is not assignable to type 'TimeInput | undefined'.
          Type 'Attributes' is missing the following properties from type 'Date': toDateString, toTimeString, toLocaleDateString, toLocaleTimeString, and 37 more.

45     recordException(exception: api.Exception, time?: api.TimeInput): void;
       ~~~~~~~~~~~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. autorelease: closed autorelease: triggered owlbot:ignore instruct owl-bot to ignore a PR size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants