-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for OTel context propagation and harmonized spans #1833
base: main
Are you sure you want to change the base?
Conversation
…e of telemetry tracing
@naseemkullah The delay has been annoying for sure. The good news is, this is being reviewed in pieces and there will hopefully be a beta release soon. |
There's one more of these in the review queue right now: Some fabulous people on our side have been working to harmonize our span design a bit more with the OTel working group's design in progress for message tracing. :) |
@hongalex The sample needs updating, but this should more or less be the finished PR now. Thanks for all the review help. |
fix: change processing span to use ack/nack instead of callback time
This is now testable in beta form. I installed in a test project like so:
The resulting package.json looks like this: {
"dependencies": {
"@google-cloud/opentelemetry-cloud-trace-exporter": "^2.1.0",
"@google-cloud/pubsub": "^4.3.3-otel-beta.1",
"@opentelemetry/sdk-trace-node": "^1.23.0",
"@opentelemetry/semantic-conventions": "^1.23.0"
}
} And then you can take a look at this sample for how to use it from JS, or this sample for how to use it from TS. We've got more reviewing to do, and merges aren't going to happen for at least a week, but this may at least make it easier to do some testing if you like. Further updates (for now) will come in as |
This PR adds support for OTel context propagation using the standard W3C headers as Pub/Sub attributes. It also harmonizes the spans we're using with the planned spans in other language libraries.
Fixes #1389
(This is the 4.x version of #1659 - I'll still be backporting to there, but the changes will go here first.)