Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set x-goog-request-params for streaming pull request #1849

Merged
merged 8 commits into from
Nov 3, 2023
Merged

fix: set x-goog-request-params for streaming pull request #1849

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f82f58
samples: create BigQuery subscription
kamalaboulhosn Jun 21, 2022
f36ea53
Merge branch 'main' into main
kamalaboulhosn Jul 6, 2022
b4044dc
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 7, 2022
719350a
Merge branch 'main' into main
feywind Jul 7, 2022
ab2b561
Merge branch 'main' into main
feywind Jul 8, 2022
d0d2862
Merge branch 'googleapis:main' into main
kamalaboulhosn Jan 24, 2023
c3ebfb0
Merge branch 'googleapis:main' into main
kamalaboulhosn Oct 31, 2023
01786f8
fix: set x-goog-request-params for streaming pull request
kamalaboulhosn Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/message-stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,13 @@ export class MessageStream extends PassThrough {
? 0
: this._subscriber.maxBytes,
};
const otherArgs = {
headers: {
'x-goog-request-params': 'subscription=' + this._subscriber.name,
},
};

const stream: PullStream = client.streamingPull({deadline});
const stream: PullStream = client.streamingPull({deadline, otherArgs});
this._replaceStream(index, stream);
stream.write(request);
}
Expand Down