Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ts): added ts style fix for src/iam.ts #352

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

vijay-qlogic
Copy link
Contributor

Fixes #311 partially for src/iam.ts (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 21, 2018
@vijay-qlogic vijay-qlogic changed the title added ts style fix for src/iam.ts refactor(ts): added ts style fix for src/iam.ts Nov 22, 2018
@JustinBeckwith
Copy link
Contributor

This ended up with a merge conflict :( PTAL?

@JustinBeckwith JustinBeckwith added the status: blocked Resolving the issue is dependent on other work. label Nov 23, 2018
@JustinBeckwith JustinBeckwith merged commit 5bec6e9 into googleapis:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants