Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix/simplify proto gen scripts #542

Merged
merged 2 commits into from Mar 11, 2019
Merged

refactor: fix/simplify proto gen scripts #542

merged 2 commits into from Mar 11, 2019

Conversation

callmehiphop
Copy link
Contributor

Per #541, this PR cleans up the proto scripts and uses mkdirp for Windows support!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2019
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍 I'd love to eventually get some Windows testing in our automated testing infrastructure (if it's not in the mix already) using libraries like rimraf and mkdirp are a good initial step to ensure cross-platform compatibility.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #542 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          16       16           
  Lines         965      965           
  Branches       86       86           
=======================================
  Hits          915      915           
  Misses         42       42           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41477af...b16882a. Read the comment docs.

@callmehiphop
Copy link
Contributor Author

@bcoe we do some Windows testing, but our current CI setup isn't very friendly to non-Googlers, so it's a little bit of a mystery to me to be honest, haha. @jkwlui could probably share some details with us!

@callmehiphop callmehiphop merged commit 84c1957 into googleapis:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants