Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: set skipLibCheck to false for ts install test #543

Merged
merged 2 commits into from Mar 11, 2019
Merged

testing: set skipLibCheck to false for ts install test #543

merged 2 commits into from Mar 11, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Mar 11, 2019

Relates to #532

Looks like our test fixture was wrong from the start! Although I'm still unsuccessful in reproducing, it may be that it was resolved in #541

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          16       16           
  Lines         965      965           
  Branches       86       86           
=======================================
  Hits          915      915           
  Misses         42       42           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c1957...fda6cf6. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          16       16           
  Lines         965      965           
  Branches       86       86           
=======================================
  Hits          915      915           
  Misses         42       42           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c1957...fda6cf6. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          16       16           
  Lines         965      965           
  Branches       86       86           
=======================================
  Hits          915      915           
  Misses         42       42           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c1957...fda6cf6. Read the comment docs.

@callmehiphop callmehiphop merged commit e7e4c5c into googleapis:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants