Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect jsdoc for Table.insert() #1369

Closed
nielm opened this issue May 18, 2021 · 0 comments · Fixed by #1371
Closed

Incorrect jsdoc for Table.insert() #1369

nielm opened this issue May 18, 2021 · 0 comments · Fixed by #1371
Assignees
@skuruppu
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@nielm
Copy link

nielm commented May 18, 2021

JSDoc for Table.Insert documents the options parameter as DeleteRowsOptions -- it should be InsertRowsOptions
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label May 18, 2021
@nielm nielm mentioned this issue May 18, 2021
Closed
@zoercai zoercai added priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. labels May 19, 2021
@hengfengli hengfengli mentioned this issue May 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skuruppu skuruppu

Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
3 participants
@nielm @skuruppu @zoercai