-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix jsdoc in Table.insert() #1370
Conversation
@nielm The conventionalcommits check fails. I think the commit message needs to follow a convention. |
JSdoc incorrectly had DeleteRowsOptions as options param to Table.insert()
fixed |
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
========================================
Coverage 98.60% 98.60%
========================================
Files 23 23
Lines 21950 21964 +14
Branches 1238 1112 -126
========================================
+ Hits 21644 21658 +14
Misses 297 297
Partials 9 9
Continue to review full report at Codecov.
|
Any idea what causes the check failures and what I can do to fix them? |
@stephenplusplus Hi Stephen, do you have any idea why the lint fails? This PR doesn't touch |
@bcoe did we change lint settings? There are so many lint failures that didn't exist before. |
@skuruppu the library we rely on for linting changed these rules in a minor version, so we'll need to update and run |
@bcoe It's strange. I ran |
I got the output:
The version is different from the CI check (version: 14). Is this an issue? |
@nielm I think I know what the issue is. I've had the same trouble for a long time as well. When we run |
@skuruppu @hengfengli I think we should create separate PR to fix the lint. I will create it shortly. |
Since a PR #1371 to fix all doc issues has been created, I think this PR can be closed. |
JSdoc incorrectly had DeleteRowsOptions as options param to Table.insert()
Fixes #1369 馃