Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: update library to use Node 12 #1637

Merged
merged 7 commits into from
Jun 7, 2022
Merged

build!: update library to use Node 12 #1637

merged 7 commits into from
Jun 7, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented May 17, 2022

Migrate library to Node 12

@sofisl sofisl requested review from a team as code owners May 17, 2022 02:24
@generated-files-bot
Copy link

generated-files-bot bot commented May 17, 2022 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels May 17, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels May 17, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 19, 2022
@asthamohta asthamohta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2022
@asthamohta
Copy link
Contributor

@sofisl the test(10) is not running, any idea why?

@asthamohta asthamohta merged commit 994acf3 into main Jun 7, 2022
@asthamohta asthamohta deleted the migrateToNode12 branch June 7, 2022 16:21
@release-please release-please bot mentioned this pull request Jun 7, 2022
Merged
@21m57 21m57 mentioned this pull request Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

@asthamohta asthamohta asthamohta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sofisl @asthamohta @alexander-fenster @yoshi-kokoro