Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionLeakError does not contain a useful stack #755

Closed
olavloite opened this issue Dec 16, 2019 · 0 comments · Fixed by #756
Closed

SessionLeakError does not contain a useful stack #755

olavloite opened this issue Dec 16, 2019 · 0 comments · Fixed by #756
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@olavloite
Copy link
Contributor

The SessionLeakError should contain a stacktrace of the method that checked out a session from the pool, but because of an async method call in the _acquire method, the stacktrace only contains the _acquire method itself, and no other useful information.

This hinders debugging of #716
@olavloite olavloite added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 16, 2019
@olavloite olavloite self-assigned this Dec 16, 2019
@olavloite olavloite mentioned this issue Dec 16, 2019
Merged
@skuruppu skuruppu mentioned this issue Dec 17, 2019
Closed
@google-cloud-label-sync google-cloud-label-sync bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: get stacktrace before any async method call olavloite/nodejs-spanner
1 participant
@olavloite