fix: get stacktrace before any async method call #756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current stacktrace that is included in a
SessionLeakError
only contains the_acquire
method itself, as the_acquire
method calls an async method before getting the stacktrace. This change moves the call to get the caller stacktrace to the beginning of the method, which ensures that the stacktrace does contain the information that is needed.This will also give us additional information that would be valuable to debug #716
Fixes #755