Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset buffered chunked value before retry #1397

Merged
merged 11 commits into from
Jun 25, 2021

Commits on Jun 14, 2021

  1. fix: reset buffered chunked value before retry

    Retrying a stream of PartialResultSets must correctly reset to the last state that it
    had when it received a PartialResultSet with a resume token. That means:
    1. The pending value that should be merged with the next result should be reset to the
       pending value of the last PartialResultSet with a resume token.
    2. The stream must correctly check for the existence of a resume token.
    3. The stream must ensure that all values that are already in the pipeline must be
       handled before resetting the stream to the last resume token to ensure that no
       PartialResultSet is added twice to the stream.
    
    Fixes googleapis#1392
    olavloite committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    2f09e5d View commit details
    Browse the repository at this point in the history
  2. chore: cleanup

    olavloite committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    db6d48a View commit details
    Browse the repository at this point in the history
  3. chore: linter

    olavloite committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    46d4563 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8bdbdc2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fba762d View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Configuration menu
    Copy the full SHA
    9a7ccf0 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. chore: fix lint errors

    olavloite committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    c8e612d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    19be9e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9aed31d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Configuration menu
    Copy the full SHA
    f5ce41a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    085243d View commit details
    Browse the repository at this point in the history