-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reset buffered chunked value before retry #1397
Merged
Merged
Commits on Jun 14, 2021
-
fix: reset buffered chunked value before retry
Retrying a stream of PartialResultSets must correctly reset to the last state that it had when it received a PartialResultSet with a resume token. That means: 1. The pending value that should be merged with the next result should be reset to the pending value of the last PartialResultSet with a resume token. 2. The stream must correctly check for the existence of a resume token. 3. The stream must ensure that all values that are already in the pipeline must be handled before resetting the stream to the last resume token to ensure that no PartialResultSet is added twice to the stream. Fixes googleapis#1392
Configuration menu - View commit details
-
Copy full SHA for 2f09e5d - Browse repository at this point
Copy the full SHA 2f09e5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for db6d48a - Browse repository at this point
Copy the full SHA db6d48aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46d4563 - Browse repository at this point
Copy the full SHA 46d4563View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bdbdc2 - Browse repository at this point
Copy the full SHA 8bdbdc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fba762d - Browse repository at this point
Copy the full SHA fba762dView commit details
Commits on Jun 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9a7ccf0 - Browse repository at this point
Copy the full SHA 9a7ccf0View commit details
Commits on Jun 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c8e612d - Browse repository at this point
Copy the full SHA c8e612dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19be9e5 - Browse repository at this point
Copy the full SHA 19be9e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9aed31d - Browse repository at this point
Copy the full SHA 9aed31dView commit details
Commits on Jun 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f5ce41a - Browse repository at this point
Copy the full SHA f5ce41aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 085243d - Browse repository at this point
Copy the full SHA 085243dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.