Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace projectId placeholder in formatted names #1407

Merged
merged 6 commits into from
Jun 30, 2021

Commits on Jun 25, 2021

  1. fix: replace projectId placeholder in formatted names

    The {{projectId}} placeholder was only replaced in the names of the objects that
    were included in the requests, and not in the headers and formatted names. This
    would cause the CLOUD_RESOURCE_HEADER to be filled with the {{projectId}} placeholder
    instead of the actual value.
    As the actual project ID is gotten through an async method, and the constructor and
    `instance` methods are synchronous, we can only replace the actual values once it is
    retrieved for the first request.
    
    Fixes googleapis#1375
    olavloite committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    b982e2d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e76fb6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3ef406 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Configuration menu
    Copy the full SHA
    9cfa9a6 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Configuration menu
    Copy the full SHA
    36cb51a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6613f07 View commit details
    Browse the repository at this point in the history