Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix p-retry is accepting function not object/promise #312

Merged
merged 2 commits into from
Aug 28, 2018

Conversation

eric4545
Copy link
Contributor

@eric4545 eric4545 commented Aug 27, 2018

Fixes #311

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 27, 2018
@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #312 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   99.61%   99.53%   -0.08%     
==========================================
  Files          12       12              
  Lines        1294     1295       +1     
==========================================
  Hits         1289     1289              
- Misses          5        6       +1
Impacted Files Coverage Δ
src/database.js 97.37% <0%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8319574...1bd8dea. Read the comment docs.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 27, 2018
@ghost ghost assigned JustinBeckwith Aug 28, 2018
@JustinBeckwith JustinBeckwith merged commit abcb90c into googleapis:master Aug 28, 2018
@eric4545 eric4545 deleted the 311 branch August 29, 2018 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants