This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
fix(samples): storage import #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 32 32
=====================================
Hits 32 32Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Sep 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the samples test that are failing due to Storage changing its library signature. However, 2 tests are still failing after this fix because of assertion failures (back-end algo?).
Currently blocking release of v2.1.0