Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose chunkSize param for CreateResumableUploadOptions #1754

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

danielbankhead
Copy link
Member

No description provided.

@danielbankhead danielbankhead requested review from a team as code owners January 13, 2022 17:25
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 13, 2022
@@ -190,6 +190,7 @@ export type PredefinedAcl =
| 'publicRead';

export interface CreateResumableUploadOptions {
chunkSize?: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need its own documentation somewhere, or is it covered by

* Create a separate request per chunk.
?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call-out, added some more discoverable documentation

@danielbankhead danielbankhead merged commit 3acfd5b into main Jan 13, 2022
@danielbankhead danielbankhead deleted the multi-upload-by-chunk-support branch January 13, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants