Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

feat: Expose chunkSize param for CreateResumableUploadOptions#1754

Merged
danielbankhead merged 2 commits intomainfrom
multi-upload-by-chunk-support
Jan 13, 2022
Merged

feat: Expose chunkSize param for CreateResumableUploadOptions#1754
danielbankhead merged 2 commits intomainfrom
multi-upload-by-chunk-support

Conversation

@danielbankhead
Copy link
Copy Markdown
Contributor

No description provided.

@danielbankhead danielbankhead requested review from a team January 13, 2022 17:25
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 13, 2022
Comment thread src/file.ts
| 'publicRead';

export interface CreateResumableUploadOptions {
chunkSize?: number;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need its own documentation somewhere, or is it covered by

* Create a separate request per chunk.
?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call-out, added some more discoverable documentation

@danielbankhead danielbankhead merged commit 3acfd5b into main Jan 13, 2022
@danielbankhead danielbankhead deleted the multi-upload-by-chunk-support branch January 13, 2022 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants