Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Start Resumable Uploads #55

Closed
stephenplusplus opened this issue Oct 10, 2017 · 0 comments
Closed

Smart Start Resumable Uploads #55

stephenplusplus opened this issue Oct 10, 2017 · 0 comments
Assignees
Labels
api: storage Issues related to the googleapis/nodejs-storage API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@stephenplusplus
Copy link
Contributor

Some environments don't have writable $HOME directories, which will return an error from gcs-resumable-upload. We should confirm we can write to the directory before attempting a resumable upload.

Here are the ideal scenarios:

file.createWriteStream()

No options.resumable argument supplied.

  • Can write to home directory? Start resumable upload.
  • Cannot write to home directory? Fall back to simple upload.

We can explain in the docs we will attempt a resumable upload, but won't guarantee it. In either case, the user does not know which was used.

file.createWriteStream({ resumable: true })

Resumable upload was explicitly requested.

  • Can write to home directory? Start resumable upload.
  • Cannot write to home directory? Emit an error, close the stream.

file.createWriteStream({ resumable: false })

Resumable upload was explicitly denied.

  • Do not attempt to write to home directory.
  • Start simple upload.
@lukesneeringer lukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Nov 10, 2017
@stephenplusplus stephenplusplus removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Feb 20, 2018
@ghost ghost assigned stephenplusplus Apr 2, 2018
@ghost ghost removed the type: enhancement label Apr 2, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants