Smart-start resumable uploads. #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
alexander-fenster
approved these changes
Apr 2, 2018
ghost
removed
the
cla: yes
This was referenced Apr 27, 2018
Merged
stephenplusplus
commented
Aug 28, 2019
| @@ -192,6 +196,8 @@ util.inherits(File, common.ServiceObject); | |||
| * @param {string|Bucket|File} destination Destination file. | |||
| * @param {object} [options] Configuration options. See an | |||
| * [Object resource](https://cloud.google.com/storage/docs/json_api/v1/objects#resource). | |||
| * @param {string} [options.keepAcl] Retain the ACL for the new file. | |||
There was a problem hiding this comment.
Woops. Must have been working on this feature at the same time and left this in by mistake.
This was referenced Aug 29, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55