-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file): allow setting configPath of resumable upload #642
feat(file): allow setting configPath of resumable upload #642
Conversation
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 9 9
Lines 874 874
Branches 99 99
=======================================
Hits 856 856
Misses 9 9
Partials 9 9
Continue to review full report at Codecov.
|
We actually don't want to merge this yet, as I think we are rolling back gcs-resumable-upload to pre 1.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not merge yet.
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 10 10
Lines 1152 1152
Branches 288 288
=======================================
Hits 1094 1094
Misses 30 30
Partials 28 28
Continue to review full report at Codecov.
|
@jkwlui @stephenplusplus this is getting a tad moldy. Do we have clear steps to get it merged? |
@stephenplusplus @jkwlui I'm going to close this out for now. |
@jkwlui @JustinBeckwith this one should be ready to go now. Please take a look! |
Fixes googleapis/gcs-resumable-upload#132
Blocked