samples: upload without authentication #1711
Conversation
google-cla
bot
added
the
cla: yes
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
api: storage
…s/nodejs-storage into shaffeeullah/uploadwithoutauth
|
Warning: This pull request is touching the following templated files:
|
samples/README.md
Outdated
| @@ -1855,6 +1856,23 @@ __Usage:__ | |||
|
|
|||
|
|
|||
|
|
|||
| ### Upload Without Auth | |||
There was a problem hiding this comment.
This is proper sentence case so it'll render correctly when added to docs. Also provides more detail as to what "auth" means.
There was a problem hiding this comment.
This is autogenerated by a bot and cannot be changed (without a ton of effort, like contacting the team that wrote the bot)
There was a problem hiding this comment.
I think I can change the word "auth" to "authenticating" by renaming the file the sample is in. Do you think i should make that change?
There was a problem hiding this comment.
I think it'd be best to make that change. "Upload without auth" seems like it could imply many things (upload without authenticating, upload without OAuth, etc)
samples/uploadWithoutAuth.js
Outdated
| async function uploadWithoutAuthentication() { | ||
| const file = storage.bucket(bucketName).file(destFileName); | ||
| let location; // endpoint to which we should upload the file | ||
|
|
There was a problem hiding this comment.
I'm wondering if this sample should be split into two separate samples as to not overload, but it's readable so not completely against it.
There was a problem hiding this comment.
I think if we separate this into two samples, we run the risk of someone missing one of the samples and only learning one way it could be done. It also depends on how the page is structured though. @cbonnie do you have thoughts here?
There was a problem hiding this comment.
We can definitely split this up into two samples and make it clear (in writing) that there's two ways to do the task.
There was a problem hiding this comment.
You could nest them in the same region block: https://cloud.google.com/storage/docs/listing-objects#code-samples is an example
There was a problem hiding this comment.
oh cool! i didnt realize that. thanks for this example. i will make this change
…oogleapis/nodejs-storage into shaffeeullah/uploadwithoutauth
shaffeeullah
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
| }, | ||
| }); | ||
|
|
||
| // endpoint to which we should upload the file |
…feeullah/uploadwithoutauth
This is the canonical sample for uploading data without authentication.
Tests to be written once we decide on the format of the sample.
Related customer issue: googleapis/gcs-resumable-upload#201