docs: change properties with function value to methods #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
fhinkel
changed the title
fhinkel
force-pushed
the
fhinkel-methods
branch
from
9c63fb8
to
9b6af22
Compare
bcoe
reviewed
Nov 18, 2021
| @@ -629,7 +629,10 @@ class Bucket extends ServiceObject { | |||
| acl: Acl; | |||
| iam: Iam; | |||
|
|
|||
| getFilesStream: (query?: GetFilesOptions) => Readable; | |||
| getFilesStream(query?: GetFilesOptions): Readable { | |||
| // placeholder body, overwritten in constructor | |||
There was a problem hiding this comment.
This seems reasonble to me, but I would open a ticket in parser to fix this issue, and reference the ticket # here.
There was a problem hiding this comment.
You mean in api-documnter? Yeah, I can open an issue there.
There was a problem hiding this comment.
done: microsoft/rushstack#3031
bcoe
approved these changes
Nov 18, 2021
shaffeeullah
suggested changes
Nov 18, 2021
Sure! |
fhinkel
changed the title
shaffeeullah
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, see b/206943288