Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert skip validation #1718

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Conversation

shaffeeullah
Copy link
Contributor

@shaffeeullah shaffeeullah commented Nov 18, 2021

Fixes #1716
Reverts workaround logic implemented for #709 by #1063

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Nov 18, 2021
@shaffeeullah shaffeeullah marked this pull request as ready for review November 18, 2021 23:06
@shaffeeullah shaffeeullah requested review from a team as code owners November 18, 2021 23:06
@shaffeeullah shaffeeullah merged commit 0c75e33 into main Nov 19, 2021
@shaffeeullah shaffeeullah deleted the shaffeeullah/revertskipvalidation branch November 19, 2021 14:57
shaffeeullah added a commit that referenced this pull request Nov 19, 2021
fhinkel pushed a commit that referenced this pull request Nov 23, 2021
* fix: revert skip validation

* fixed logic

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
shaffeeullah added a commit that referenced this pull request Nov 24, 2021
@shaffeeullah shaffeeullah restored the shaffeeullah/revertskipvalidation branch August 8, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage write, read, and remove files: should skip validation if file is served decompressed failed
2 participants