fix: stop File.download from truncating output file on failure #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
ddelgrosso1
approved these changes
Nov 19, 2021
| const fileContents = 'abcdefghijklmnopqrstuvwxyz'; | ||
|
|
||
| fileReadStream.on('resume', () => { | ||
| fileReadStream.emit('data', fileContents); |
There was a problem hiding this comment.
Minor: for future reviewers, we may want to leave a comment as to why we're explicitly emitting twice
There was a problem hiding this comment.
Do you think the test title is sufficient? If not, we should change the test title to something more descriptive.
There was a problem hiding this comment.
I think the title is sufficient, describes what it is testing succinctly enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1713 馃