samples: Delete setPublicAccessPreventionUnspecified.js #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
|
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
frankyn
requested changes
Dec 16, 2021
|
|
||
| // Creates a client | ||
| const storage = new Storage(); | ||
| async function setPublicAccessPreventionUnspecified() { |
There was a problem hiding this comment.
There should be a test for this, could you remove it as well?
There was a problem hiding this comment.
no test. the test broke when the backend changed, so we removed it
shaffeeullah
changed the title
frankyn
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.