Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove tls for benchwrapper #816

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

jeanbza
Copy link
Member

@jeanbza jeanbza commented Aug 19, 2019

We found a way to whitelist our usage of tls-less gRPC within g3, so this is
no longer necessary. Huzzah!

We found a way to whitelist our usage of tls-less gRPC within g3, so this is
no longer necessary. Huzzah!
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2019
@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #816 into master will increase coverage by 0.65%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
+ Coverage   94.39%   95.05%   +0.65%     
==========================================
  Files          10       10              
  Lines        1160     1152       -8     
  Branches      288      288              
==========================================
  Hits         1095     1095              
+ Misses         37       29       -8     
  Partials       28       28
Impacted Files Coverage Δ
bin/benchwrapper.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 604e564...71c6a72. Read the comment docs.

@JustinBeckwith JustinBeckwith changed the title benchwrapper: remove tls test: remove tls for benchwrapper Aug 19, 2019
@JustinBeckwith JustinBeckwith merged commit 0eb689f into googleapis:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants