Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass predefined acl as destinationPredefinedAcl to qs #872

Merged
merged 6 commits into from
Oct 7, 2019

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Oct 3, 2019

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Currently optional param predefinedAcl in file#copy is not utilized properly.
As per docs API expects [destinationPredefinedAcl](https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite) as part of the qs (not Json).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #872 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
+ Coverage   95.27%   95.28%   +0.01%     
==========================================
  Files          11       11              
  Lines        1206     1209       +3     
  Branches      300      301       +1     
==========================================
+ Hits         1149     1152       +3     
  Misses         29       29              
  Partials       28       28
Impacted Files Coverage Δ
src/file.ts 98.17% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a99e9...ebf7e41. Read the comment docs.

@bcoe bcoe merged commit 09b8fa4 into googleapis:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants