Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

chore: bump version to 0.2.0 #28

Merged
merged 1 commit into from
Jun 18, 2018
Merged

chore: bump version to 0.2.0 #28

merged 1 commit into from
Jun 18, 2018

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Jun 18, 2018

Releasing v1beta1 regen (#27)

Release draft

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@jkwlui jkwlui added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 18, 2018
@jkwlui jkwlui self-assigned this Jun 18, 2018
@jkwlui jkwlui requested review from a team and JustinBeckwith June 18, 2018 20:02
@codecov-io
Copy link

codecov-io commented Jun 18, 2018

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #28   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aefb55...524f503. Read the comment docs.

@JustinBeckwith
Copy link
Contributor

General philosophy on the release notes - I'm not sure telling folks that we 'regenerated the API' is what they need to hear. I'd much rather tell them:

  • Which new methods do they get to use?
  • What methods or classes were changed?
  • What new features are there?
  • Are there any breaking changes?

Lets find a way to make this more about them :) In addition to the human description, I also like to include a change log in specific format. Can you run this command?

git log --oneline $(git describe --tags --abbrev=0 @^)..@ | pbcopy

The output from that should set you up :)

@jkwlui
Copy link
Member Author

jkwlui commented Jun 18, 2018

Alright, trying this again by following release note format from other repos :)

@jkwlui
Copy link
Member Author

jkwlui commented Jun 18, 2018

Rewritten the draft release :) @JustinBeckwith

@crwilcox
Copy link
Contributor

I can't see the draft. We usually just paste the notes into the PR description.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@jkwlui jkwlui merged commit af5c79d into master Jun 18, 2018
@jkwlui jkwlui deleted the v0.2.0 branch June 18, 2018 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants