This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
test: label v3 batch_translate test as flaky #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
approved these changes
Oct 28, 2019
| @@ -71,7 +71,7 @@ describe(REGION_TAG, () => { | |||
| await operation.promise(); | |||
| }); | |||
|
|
|||
| it('should batch translate the input text with a glossary', async () => { | |||
| it.skip('should batch translate the input text with a glossary [FLAKY]', async () => { | |||
There was a problem hiding this comment.
Just an idea. It could turn out useful to leave a code comment that links to the issue #364. That way, if the future fixer comes straight from the code, as opposed to finding the issue first, we won’t have a stale issue hanging around.
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 85 85
=====================================
Hits 85 85Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been flapping since added, labeling as flaky.