Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

test: throw on deprecation #147

Merged
merged 1 commit into from Oct 10, 2018
Merged

test: throw on deprecation #147

merged 1 commit into from Oct 10, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@ghost ghost assigned JustinBeckwith Aug 2, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2018
@stephenplusplus
Copy link
Contributor

Some throwing about grpc.load:

> @google-cloud/vision@0.21.1 system-test C:\Users\sawch\dev\nodejs-vision
> mocha system-test/*.js smoke-test/*.js --timeout 600000

DeprecationWarning: grpc.load: Use the @grpc/proto-loader module with grpc.loadPackageDefinition instead
    at GrpcClient.load (C:\Users\sawch\dev\nodejs-vision\node_modules\google-gax\src\grpc.ts:224:27)
    at new OperationsClientBuilder (C:\Users\sawch\dev\nodejs-vision\node_modules\google-gax\src\operations_client.ts:440:38)
    at new lro (C:\Users\sawch\dev\nodejs-vision\node_modules\google-gax\src\index.ts:58:10)
    at new ImageAnnotatorClient (C:\Users\sawch\dev\nodejs-vision\src\v1\image_annotator_client.js:116:29)
    at Suite.<anonymous> (C:\Users\sawch\dev\nodejs-vision\system-test\vision.js:40:16)
    at Object.create (C:\Users\sawch\dev\nodejs-vision\node_modules\mocha\lib\interfaces\common.js:112:19)
    at context.describe.context.context (C:\Users\sawch\dev\nodejs-vision\node_modules\mocha\lib\interfaces\bdd.js:40:27)
    at Object.<anonymous> (C:\Users\sawch\dev\nodejs-vision\system-test\vision.js:28:1)
    at Module._compile (module.js:652:30)
    at Module._extensions..js (module.js:663:10)
    at Object.extensions..js (C:\Users\sawch\dev\nodejs-vision\node_modules\espower-loader\index.js:47:13)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at C:\Users\sawch\dev\nodejs-vision\node_modules\mocha\lib\mocha.js:250:27
    at Array.forEach (<anonymous>)
    at Mocha.loadFiles (C:\Users\sawch\dev\nodejs-vision\node_modules\mocha\lib\mocha.js:247:14)
    at Mocha.run (C:\Users\sawch\dev\nodejs-vision\node_modules\mocha\lib\mocha.js:576:10)
    at Object.<anonymous> (C:\Users\sawch\dev\nodejs-vision\node_modules\mocha\bin\_mocha:637:18)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3

@JustinBeckwith
Copy link
Contributor Author

Looks like another one on grpc and gax :)

@ghost ghost assigned JustinBeckwith Aug 6, 2018
@JustinBeckwith JustinBeckwith removed their assignment Aug 6, 2018
@ghost ghost assigned JustinBeckwith and jkwlui Aug 8, 2018
@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #147   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b118061...f283232. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants