This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
[DO NOT MERGE] Make Product Search tests run #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `npm test` wasn't running these samples I wasn't sure of a better, more idiomatic way to hook up these tests so that they run. They weren't running on CI either (and were failing!)
beccasaurus
added
the
do not merge
googlebot
added
the
cla: yes
|
Just wanted to share this diff, @nirupa-kumar taking a look at failures – closing! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mv samples/productSearch/system-test/* samples/system-test/Running
npm testwasn't running these samples (not locally or on CI)Simply moved them into the primary sample test directory as an easy fix
Unfortunately the tests are failing (see the CI test results on this PR)
I spent a little while trying to get them to work and made a bit of progress, but don't have time to truly resolve them. So creating an issue to track it. And this PR so that the tests can actually be run.
This PR may be deleted without merge. I want to provide it so that the person fixing the tests can use this to immediately see failures with
npm testSee issue: #266