Skip to content

Commit

Permalink
feat: Remove deletion of model upload staging bucket in system tests
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 602531376
  • Loading branch information
matthew29tang authored and Copybara-Service committed Jan 30, 2024
1 parent b2458ec commit b9b373b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions tests/system/aiplatform/test_model_upload.py
Expand Up @@ -28,7 +28,7 @@
_XGBOOST_MODEL_URI = "gs://cloud-samples-data-us-central1/vertex-ai/google-cloud-aiplatform-ci-artifacts/models/iris_xgboost/model.bst"


@pytest.mark.usefixtures("delete_staging_bucket", "tear_down_resources")
@pytest.mark.usefixtures("tear_down_resources")
class TestModelUploadAndUpdate(e2e_base.TestEndToEnd):

_temp_prefix = "temp_vertex_sdk_e2e_model_upload_test"
Expand Down Expand Up @@ -59,8 +59,6 @@ def test_upload_and_deploy_xgboost_model(self, shared_state):
# Checking that the bucket is auto-generated
assert "-vertex-staging-" in staging_bucket.name

shared_state["bucket"] = staging_bucket

# Currently we need to explicitly specify machine type.
# See https://github.com/googleapis/python-aiplatform/issues/773
endpoint = model.deploy(machine_type="n1-standard-2")
Expand Down
4 changes: 1 addition & 3 deletions tests/system/aiplatform/test_model_version_management.py
Expand Up @@ -28,7 +28,7 @@
from tests.system.aiplatform import test_model_upload


@pytest.mark.usefixtures("delete_staging_bucket", "tear_down_resources")
@pytest.mark.usefixtures("tear_down_resources")
class TestVersionManagement(e2e_base.TestEndToEnd):

_temp_prefix = "temp_vertex_sdk_e2e_model_upload_test"
Expand Down Expand Up @@ -66,8 +66,6 @@ def test_upload_deploy_manage_versioned_model(self, shared_state):
# Checking that the bucket is auto-generated
assert "-vertex-staging-" in staging_bucket.name

shared_state["bucket"] = staging_bucket

assert model.version_description == version_description
assert model.version_aliases == version_aliases
assert "default" in model.version_aliases
Expand Down

0 comments on commit b9b373b

Please sign in to comment.