Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed resources should be passed in by an environment variables. See External Resources section of the sample style guide. #51

Closed
aribray opened this issue Nov 11, 2020 · 0 comments
Closed

Fixed resources should be passed in by an environment variables. See External Resources section of the sample style guide. #51

aribray opened this issue Nov 11, 2020 · 0 comments
Assignees
@aribray
Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@aribray
Copy link
Contributor

aribray commented Nov 11, 2020

Fixed resources should be passed in by an environment variables. See External Resources section of the sample style guide.

Users and Googlers without access to these resources should be able to run tests on these samples w/o having to modify them

Originally posted by @kurtisvg in #13 (comment)
@aribray aribray self-assigned this Nov 11, 2020
@aribray aribray mentioned this issue Nov 11, 2020
Merged
4 tasks
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 18, 2021
@JustinBeckwith JustinBeckwith added the api: aiplatform Issues related to the AI Platform API. label Feb 18, 2021
@vinnysenthil vinnysenthil added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Feb 18, 2021
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Feb 18, 2021
@vinnysenthil vinnysenthil added the samples Issues that are directly related to samples. label Feb 18, 2021
@aribray aribray closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aribray aribray

Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustinBeckwith @vinnysenthil @yoshi-automation @aribray