Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate sample and sample tests - Batch 3 of 5 #13

Merged
merged 19 commits into from Nov 11, 2020
Merged

feat: Migrate sample and sample tests - Batch 3 of 5 #13

merged 19 commits into from Nov 11, 2020

Conversation

vinnysenthil
Copy link
Contributor

@vinnysenthil vinnysenthil commented Sep 25, 2020 •
edited by aribray

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9 (Batch 3 of 5) 🦕

Github issues raised by this PR: #51 , #52

@vinnysenthil vinnysenthil requested review from dizcology and a team as code owners September 25, 2020 21:59
@vinnysenthil vinnysenthil requested review from kurtisvg and removed request for a team September 25, 2020 21:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020
@release-please release-please bot requested a review from a team as a code owner September 25, 2020 23:09
kurtisvg
kurtisvg suggested changes Sep 26, 2020
View reviewed changes
samples/export_model_sample.py Show resolved Hide resolved
samples/export_model_sample.py Outdated Show resolved Hide resolved
samples/export_model_sample.py Outdated Show resolved Hide resolved
samples/export_model_sample.py Outdated Show resolved Hide resolved
samples/export_model_sample.py Outdated Show resolved Hide resolved
samples/get_batch_prediction_job_sample.py Outdated Show resolved Hide resolved
samples/get_model_evaluation_sample.py Outdated Show resolved Hide resolved
samples/tests/export_model_tables_classification_test.py Outdated Show resolved Hide resolved
samples/tests/export_model_tables_classification_test.py Outdated Show resolved Hide resolved
samples/tests/export_model_tables_classification_test.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 26, 2020
@dizcology dizcology added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
@busunkim96 busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
@busunkim96
Copy link
Contributor

The usual flow is to merge to the main branch and then cut the release PR. Is it possible to change the branch you are merging into to master?

@dizcology This is likely also the the samples presubmit is missing. The kokoro configs added in #16 aren't present in the release-v0.2.0 branch.

@vinnysenthil vinnysenthil changed the base branch from release-v0.2.0 to sample-final-stage September 30, 2020 23:41
kurtisvg
kurtisvg suggested changes Oct 2, 2020
View reviewed changes
samples/create_custom_job_sample.py Outdated Show resolved Hide resolved
samples/export_model_sample.py Outdated Show resolved Hide resolved
samples/get_batch_prediction_job_sample.py Outdated Show resolved Hide resolved
samples/tests/export_model_tables_classification_test.py Outdated Show resolved Hide resolved
samples/get_model_evaluation_sample.py Outdated Show resolved Hide resolved
@snippet-bot
Copy link

snippet-bot bot commented Nov 7, 2020 •
edited

Here is the summary of possible violations 😱

There are 14 possible violations for not having product prefix.

Here is the summary of changes.

You added 14 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label.

kurtisvg
kurtisvg suggested changes Nov 9, 2020
View reviewed changes
Copy link

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've copy/pasted several comments from previous reviews that weren't addressed.

samples/tests/get_model_test.py Show resolved Hide resolved
samples/create_custom_job_sample.py Outdated Show resolved Hide resolved
samples/create_custom_job_sample.py Outdated Show resolved Hide resolved
samples/create_custom_job_sample.py Show resolved Hide resolved
@kurtisvg
Copy link

Please include the issue number for tracking the outstanding work before submitting.

This was referenced Nov 11, 2020
Closed
Closed
@dizcology dizcology merged commit efc405f into sample-final-stage Nov 11, 2020
@sgreenberg sgreenberg mentioned this pull request Nov 12, 2020
Closed
@vinnysenthil vinnysenthil deleted the sample-staging-3 branch December 3, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aribray aribray aribray left review comments

@dizcology dizcology dizcology approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@aribray aribray

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vinnysenthil @busunkim96 @kurtisvg @dizcology @aribray @yoshi-kokoro