Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resources should be passed in by environment variables (2/2) #52

Closed
aribray opened this issue Nov 11, 2020 · 0 comments
Closed

Fixed resources should be passed in by environment variables (2/2) #52

aribray opened this issue Nov 11, 2020 · 0 comments
Assignees
Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@aribray
Copy link
Contributor

aribray commented Nov 11, 2020

Essentially what we want here is that I as a developer, should be able to run the tests on these samples without modifying them to confirm they still work. However unless I'm on the team maintaining the samples, I likely don't have access to the resources it's tested with. By using env variables means all I need to do when running locally is change the env var, and not worry about changing the model ids when there is a problem.

So something like this is perfectly acceptable:

resource_id = os.getenv("YOUR-RESOURCE-NAME")

For bonus points you can include a link to instructions for creating the resource, if you really want to make it accessible for other developers.

Originally posted by @kurtisvg in #13 (comment)

@aribray aribray self-assigned this Nov 11, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 18, 2021
@JustinBeckwith JustinBeckwith added the api: aiplatform Issues related to the AI Platform API. label Feb 18, 2021
@vinnysenthil vinnysenthil added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Feb 18, 2021
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Feb 18, 2021
@vinnysenthil vinnysenthil added the samples Issues that are directly related to samples. label Feb 18, 2021
@aribray aribray closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants