Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make display_name parameter optional for all resources #853

Closed
Ark-kun opened this issue Nov 18, 2021 · 0 comments · Fixed by #882
Closed

Make display_name parameter optional for all resources #853

Ark-kun opened this issue Nov 18, 2021 · 0 comments · Fixed by #882
Assignees
Labels
api: aiplatform Issues related to the AI Platform API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 18, 2021

I think we should try to reduce the number of required parameters that the user has to specify to be able to call a given API. The display_name is easy to generate in a way that will satisfy most users.

I propose to mark the display_name parameter as optional and generate it as <Resource> 2021-11-18 15:28:01 by default.

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Nov 18, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 19, 2021
@morgandu morgandu added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Nov 23, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 5, 2022
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-aiplatform/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #853 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants