Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate sample and sample tests - Batch 1 of 5 #11

Merged
merged 18 commits into from Nov 2, 2020
Merged

feat: Migrate sample and sample tests - Batch 1 of 5 #11

merged 18 commits into from Nov 2, 2020

Conversation

vinnysenthil
Copy link
Contributor

@vinnysenthil vinnysenthil commented Sep 25, 2020 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9 (Batch 1 of 5) 🦕

@vinnysenthil vinnysenthil requested review from dizcology and a team as code owners September 25, 2020 21:57
@vinnysenthil vinnysenthil requested review from tmatsuo and removed request for a team September 25, 2020 21:57
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020
@release-please release-please bot requested a review from a team as a code owner September 25, 2020 23:09
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 26, 2020
@dizcology dizcology added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 28, 2020
@vinnysenthil vinnysenthil changed the base branch from release-v0.2.0 to master September 29, 2020 17:32
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
@vinnysenthil vinnysenthil added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 29, 2020
@vinnysenthil vinnysenthil changed the base branch from master to sample-final-stage September 30, 2020 23:39
@vinnysenthil vinnysenthil removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 30, 2020
vinnysenthil added a commit that referenced this pull request Oct 9, 2020
@vinnysenthil
Add pytest to requirements.txt from PR #11
4642de1
tmatsuo
tmatsuo reviewed Oct 29, 2020
View reviewed changes
samples/create_dataset_image_sample.py Outdated Show resolved Hide resolved
samples/tests/cancel_training_pipeline_test.py Show resolved Hide resolved
samples/tests/create_batch_prediction_job_video_classification_test.py Show resolved Hide resolved
samples/tests/create_batch_prediction_job_video_object_tracking_test.py Show resolved Hide resolved
samples/tests/create_data_labeling_job_images_test.py Show resolved Hide resolved
samples/tests/create_dataset_image_test.py Show resolved Hide resolved
samples/tests/create_dataset_tabular_bigquery_test.py Show resolved Hide resolved
samples/tests/create_dataset_tabular_gcs_test.py Show resolved Hide resolved
samples/tests/create_dataset_test.py Show resolved Hide resolved
samples/tests/create_dataset_video_test.py Show resolved Hide resolved
tmatsuo
tmatsuo reviewed Nov 2, 2020
View reviewed changes
Copy link

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see one split without asserting.

tmatsuo
tmatsuo reviewed Nov 2, 2020
View reviewed changes
Copy link

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tests are failing.
Maybe you can just put the test files in the same directory as the samples?

@vinnysenthil
Copy link
Contributor Author

@tmatsuo - Added that last assertion.

The test have dependencies on samples in other batch PRs. The tests will successfully run before we merge the sample-final-stage -> master PR.

tmatsuo
tmatsuo reviewed Nov 2, 2020
View reviewed changes
Copy link

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll make the final approval when we see the tests are passing!

@vinnysenthil vinnysenthil merged commit c37c8ef into sample-final-stage Nov 2, 2020
@vinnysenthil vinnysenthil mentioned this pull request Nov 2, 2020
Merged
4 tasks
@vinnysenthil vinnysenthil deleted the sample-staging-1 branch December 3, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo requested changes

@dizcology dizcology Awaiting requested review from dizcology

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add samples and sample tests
5 participants
@vinnysenthil @tmatsuo @dizcology @yoshi-kokoro @busunkim96