Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sample tests decouple #124

Merged
merged 6 commits into from
Dec 8, 2020
Merged

chore: sample tests decouple #124

merged 6 commits into from
Dec 8, 2020

Conversation

dizcology
Copy link
Contributor

Refactor sample tests.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@dizcology dizcology changed the title chore: move shared fixtures into conftest.py chore: sample tests decouple Dec 7, 2020
@dizcology dizcology marked this pull request as ready for review December 8, 2020 05:54
@dizcology dizcology requested a review from a team as a code owner December 8, 2020 05:54
@dizcology dizcology requested review from engelke and removed request for a team December 8, 2020 05:54
engelke
engelke approved these changes Dec 8, 2020
View reviewed changes
Copy link

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dizcology dizcology merged commit 6096ce7 into googleapis:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dizcology @engelke