Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate sample and sample tests - Batch 4 of 5 #14

Merged
merged 10 commits into from Nov 12, 2020
Merged

feat: Migrate sample and sample tests - Batch 4 of 5 #14

merged 10 commits into from Nov 12, 2020

Conversation

vinnysenthil
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9 (Batch 4 of 5) 🦕

@vinnysenthil vinnysenthil requested review from dizcology and a team as code owners September 25, 2020 22:00
@vinnysenthil vinnysenthil requested review from dinagraves and removed request for a team September 25, 2020 22:00
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020
@release-please release-please bot requested a review from a team as a code owner September 25, 2020 23:09
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 26, 2020
@vinnysenthil vinnysenthil changed the base branch from release-v0.2.0 to sample-final-stage September 30, 2020 23:42
dinagraves
dinagraves reviewed Oct 3, 2020
View reviewed changes
samples/get_model_evaluation_text_sentiment_analysis_sample.py Outdated Show resolved Hide resolved
samples/get_model_evaluation_text_sentiment_analysis_sample.py Outdated Show resolved Hide resolved
samples/get_model_evaluation_video_classification_sample.py Outdated Show resolved Hide resolved
samples/get_model_evaluation_video_object_tracking_sample.py Outdated Show resolved Hide resolved
samples/get_training_pipeline_sample.py Outdated Show resolved Hide resolved
samples/import_data_text_sentiment_analysis_sample.py Show resolved Hide resolved
samples/import_data_video_classification_sample.py Outdated Show resolved Hide resolved
samples/import_data_video_object_tracking_sample.py Outdated Show resolved Hide resolved
samples/tests/import_data_text_classification_single_label_test.py Show resolved Hide resolved
samples/tests/import_data_text_entity_extraction_test.py Outdated Show resolved Hide resolved
@snippet-bot
Copy link

snippet-bot bot commented Nov 7, 2020 •
edited

Here is the summary of changes.

You added 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label.

@tmatsuo tmatsuo added the snippet-bot:force-run Force snippet-bot runs its logic label Nov 11, 2020
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Nov 11, 2020
@dizcology dizcology merged commit e1e3d19 into sample-final-stage Nov 12, 2020
@aribray aribray mentioned this pull request Nov 12, 2020
Closed
@vinnysenthil vinnysenthil deleted the sample-staging-4 branch December 3, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcology dizcology dizcology approved these changes

@dinagraves dinagraves Awaiting requested review from dinagraves

Assignees

@aribray aribray

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vinnysenthil @dizcology @dinagraves @tmatsuo @aribray @busunkim96