Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add kokoro 3.9 configs #175

Merged
merged 8 commits into from
Jul 29, 2021
Merged

chore: add kokoro 3.9 configs #175

merged 8 commits into from
Jul 29, 2021

Conversation

leahecole
Copy link
Contributor

@leahecole leahecole commented Jan 16, 2021

This will be blocked until

Internal CL352076910 adds 3.6, 3.8, and 3.9 internal configs (3.7 is already set up)

@leahecole leahecole requested a review from a team as a code owner January 16, 2021 00:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2021
@leahecole leahecole changed the title add kokoro 3.9 configs chore: add kokoro 3.9 configs Jan 16, 2021
@leahecole leahecole added the status: blocked Resolving the issue is dependent on other work. label Jan 16, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Apr 13, 2021
@parthea
Copy link
Contributor

parthea commented Jun 17, 2021

Hey @leahecole, Could we add the configurations to the synthtool templates here?

@parthea
Copy link
Contributor

parthea commented Jun 17, 2021

See synthtool feature request here.

@leahecole
Copy link
Contributor Author

On it - thanks for the reference @parthea

@leahecole
Copy link
Contributor Author

This will probably need a rework to instead specify the build specific project in a noxfile_config

@leahecole leahecole requested review from a team as code owners July 15, 2021 21:30
@leahecole
Copy link
Contributor Author

@parthea I was trying to follow through on my earlier comment and of course forgot what I meant. I added a noxfile_config to the model builder samples directory that calls the BUILD_SPECIFIC_GCLOUD_PROJECT - we define that value with the ucaip project in the kokoro configs. Given that kokoro configs are being sync'd with Owlbot, and we normally do a build specific project as one from our project pool, should I actually be doing this in the noxfile config?

What I think we need

'gcloud_project_env': 'string-of-project-name'

What we currently have (which references a project string defined in common.cfg

'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT'

@parthea
Copy link
Contributor

parthea commented Jul 16, 2021

Hey @leahecole ,

I'm not sure how to solve it with noxfile_config. In case it helps, this synthtool replacement in owlbot.py worked for me locally.

s.replace(".kokoro/samples/python3.*/common.cfg",
    """env_vars: \{
    key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
    value: "python-docs-samples-tests-py3.*?"
\}""",
    """env_vars: {
    key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
    value: "ucaip-sample-tests"
}""",
    flags=re.MULTILINE | re.DOTALL,
)

@parthea
Copy link
Contributor

parthea commented Jul 19, 2021

Hey @leahecole,
Please let me know if I can go ahead with adding the replacement in owlbot.py from #175 (comment)

@leahecole
Copy link
Contributor Author

That will work and I'm happy to hand it off to you!

@parthea parthea self-assigned this Jul 20, 2021
@parthea parthea removed the status: blocked Resolving the issue is dependent on other work. label Jul 21, 2021
@google-cla
Copy link

google-cla bot commented Jul 21, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 21, 2021
@parthea
Copy link
Contributor

parthea commented Jul 21, 2021

@googlebot I consent.

@google-cla google-cla bot removed the cla: no This human has *not* signed the Contributor License Agreement. label Jul 21, 2021
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2021
@parthea
Copy link
Contributor

parthea commented Jul 22, 2021

@leahecole Done, please can you take a look?

.kokoro/samples/python3.6/periodic-head.cfg Outdated Show resolved Hide resolved
.kokoro/samples/python3.7/periodic-head.cfg Outdated Show resolved Hide resolved
.kokoro/samples/python3.8/periodic-head.cfg Outdated Show resolved Hide resolved
.kokoro/samples/python3.9/periodic-head.cfg Outdated Show resolved Hide resolved
@leahecole
Copy link
Contributor Author

@parthea other than these little fixes (which very well could have been a copy paste error from me) it looks good!

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2021
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2021
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2021
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2021
Copy link
Contributor Author

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leahecole
Copy link
Contributor Author

Because I'm the original author I can't approve so perhaps another @googleapis/python-samples-owners can approve :)

@leahecole
Copy link
Contributor Author

Thanks @busunkim96 :)

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jul 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ab6d451 into master Jul 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the kokoro-3.9 branch July 29, 2021 19:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants