Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Repair GAPIC sample test failures from permission issue #309

Merged
merged 2 commits into from
Apr 13, 2021
Merged

chore: Repair GAPIC sample test failures from permission issue #309

merged 2 commits into from
Apr 13, 2021

Conversation

vinnysenthil
Copy link
Contributor

Update GCR images and GCS artifacts to be accessible by sample testing CI.

Fixes b/184550505🦕

@vinnysenthil vinnysenthil added do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples. labels Apr 12, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Apr 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 12, 2021
@vinnysenthil vinnysenthil changed the title fix: Repair GAPIC sample test failures from permission issue chore: Repair GAPIC sample test failures from permission issue Apr 12, 2021
@vinnysenthil vinnysenthil removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 13, 2021
@vinnysenthil vinnysenthil marked this pull request as ready for review April 13, 2021 15:29
@vinnysenthil vinnysenthil requested a review from a team as a code owner April 13, 2021 15:29
@vinnysenthil vinnysenthil requested review from crwilcox and removed request for a team April 13, 2021 15:29
@vinnysenthil vinnysenthil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2021
@vinnysenthil vinnysenthil merged commit f2e3fbb into master Apr 13, 2021
@vinnysenthil vinnysenthil deleted the vinnys-bug-fix branch April 13, 2021 17:21
sasha-gitg added a commit that referenced this pull request Apr 13, 2021
@sasha-gitg
chore: Repair GAPIC sample test failures from permission issue (#309) (…
40d630e 
…#312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcology dizcology dizcology approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vinnysenthil @dizcology @yoshi-kokoro