Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: disabled tests to reduce the cost & resolve quota issues #508

Merged
merged 1 commit into from
Jun 28, 2021
Merged

test: disabled tests to reduce the cost & resolve quota issues #508

merged 1 commit into from
Jun 28, 2021

Conversation

munkhuushmgl
Copy link
Contributor

@munkhuushmgl munkhuushmgl commented Jun 24, 2021 •
edited

Fixes #438 #426 #437 #413 #395 🦕

@munkhuushmgl munkhuushmgl requested review from a team as code owners June 24, 2021 19:49
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Jun 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2021
This was linked to issues Jun 24, 2021
samples.snippets.deploy_model_sample_test: test_ucaip_generated_deploy_model_sample failed #395
Closed
samples.snippets.create_training_pipeline_tabular_regression_sample_test: test_ucaip_generated_create_training_pipeline_sample failed #413
Closed
samples.snippets.create_training_pipeline_text_sentiment_analysis_sample_test: test_ucaip_generated_create_training_pipeline_text_sentiment_analysis_sample failed #426
Closed
samples.snippets.create_batch_prediction_job_bigquery_sample_test: test_ucaip_generated_create_batch_prediction_job_bigquery_sample failed #437
Closed
telpirion
telpirion approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also log an issue to track the re-enabling of tests (once we have a new testing strategy in place).

@munkhuushmgl
Copy link
Contributor Author

Tracked #511

parthea
parthea approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestion to keep tests enabled, if possible, otherwise LGTM.

samples/snippets/create_batch_prediction_job_tabular_forecasting_sample_test.py Show resolved Hide resolved
@telpirion telpirion merged commit 177aebc into googleapis:master Jun 28, 2021
ji-yaqi pushed a commit to ji-yaqi/python-aiplatform that referenced this pull request Jun 30, 2021
@munkhuushmgl @ji-yaqi
test: disabled tests to reduce the cost & resolve quota issues (googl…
48b9257 
…eapis#508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@telpirion telpirion telpirion approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
3 participants
@munkhuushmgl @parthea @telpirion