Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adds type equivalency check to value_converter test #630

Merged
merged 5 commits into from
Oct 20, 2021

Conversation

telpirion
Copy link
Contributor

This pull request adds a type equivalency check to the test_value_converter.py file. The test ensures that the value_converter module faithfully converts protobuf.Value instances to proto.Message instances.

Fixes #136 馃

@telpirion telpirion requested a review from a team as a code owner August 17, 2021 18:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Aug 17, 2021
@vinnysenthil vinnysenthil merged commit 3fd0ab7 into main Oct 20, 2021
@vinnysenthil vinnysenthil deleted the value-converter-test branch October 20, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why isinstance() doesn't work in test_value_converter.py
3 participants