Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update feature store sample code to use v1 SDK #776

Merged
merged 6 commits into from
Oct 22, 2021
Merged

chore: update feature store sample code to use v1 SDK #776

merged 6 commits into from
Oct 22, 2021

Conversation

lclc19
Copy link
Contributor

@lclc19 lclc19 commented Oct 18, 2021

No description provided.

@lclc19 lclc19 requested review from a team as code owners October 18, 2021 18:35
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Oct 18, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 18, 2021
@snippet-bot
Copy link

snippet-bot bot commented Oct 18, 2021 •
edited

Here is the summary of changes.

You are about to add 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@lclc19 lclc19 force-pushed the lclc_snippet_3 branch 2 times, most recently from 22ccd88 to 2b9c65d Compare October 18, 2021 23:17
@lclc19 lclc19 changed the title chore:update feature store sample code to use v1 SDK chore: update feature store sample code to use v1 SDK Oct 18, 2021
morgandu
morgandu suggested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@morgandu morgandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that we can simply updating the existing samples from from google.cloud import aiplatform_v1beta1 as aiplatform to from google.cloud import aiplatform, there is no need to change the rest of the sample and sample testing.

samples/snippets/feature_store_service/batch_create_features_sample_test.py Outdated Show resolved Hide resolved
@lclc19 lclc19 merged commit da03785 into googleapis:main Oct 22, 2021
@lclc19 lclc19 deleted the lclc_snippet_3 branch October 22, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgandu morgandu morgandu approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96 busunkim96 was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lclc19 @morgandu